Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix property not found warning in 'Hide Private Properties' plugin #13

Merged
merged 2 commits into from
Feb 21, 2024
Merged

[Fix] Fix property not found warning in 'Hide Private Properties' plugin #13

merged 2 commits into from
Feb 21, 2024

Conversation

JostMK
Copy link
Contributor

@JostMK JostMK commented Feb 19, 2024

A fix for the warning printed when starting the project with this plugin enabled (see #11 ).

  • Added an early return in case the object does not have the property 'scene_file_path' using a custom property check function that does not produce a warning.
  • Updated version to 1.1.2 in README.md and plugin.cfg to document changes

I hope everything is up to your standards with this PR, if not feel free to correct me.

(Sorry for #12 but I had to setup commit verification first, first time doing this ..I hope it works now)

@IceflowRE IceflowRE linked an issue Feb 20, 2024 that may be closed by this pull request
@IceflowRE
Copy link
Member

(Sorry for #12 but I had to setup commit verification first, first time doing this ..I hope it works now)

No worries. But remember you can always force push your branch changing the content of your PR. And welcome :)

@JostMK
Copy link
Contributor Author

JostMK commented Feb 20, 2024

you can always force push your branch changing the content of your PR.

Good to know, thanks for the advice :)

@IceflowRE IceflowRE merged commit a104a38 into kenyoni-software:main Feb 21, 2024
1 check passed
@IceflowRE
Copy link
Member

Thank you! 🎉

@JostMK JostMK deleted the hide_private_properties_warning_fix branch February 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

'Hide Private Properties' plugin prints warning when starting project
2 participants