Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for subnet and eni based flow logs #76

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Adding support for subnet and eni based flow logs #76

wants to merge 4 commits into from

Conversation

r-d-w
Copy link

@r-d-w r-d-w commented Dec 5, 2024

This adds support for subnet and eni based flow logs... if getting the entire VPC is too much for some reason...

@jryburn jryburn requested a review from jksprattler December 6, 2024 05:46
@jryburn
Copy link

jryburn commented Dec 6, 2024 •
edited
Loading

@jksprattler My Terraform knowledge is pretty thin. Would you mind reviewing this PR for us?

jksprattler
jksprattler reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jksprattler jksprattler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jryburn this is still in draft. once ready this needs to be tested and validated it works properly. it should also be checked against what we present to the customer in the portal here to ensure no api changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jksprattler jksprattler jksprattler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-d-w @jryburn @jksprattler