Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove window event listeners when plugin is destroyed #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielkorte
Copy link

Currently, once the plugin is destroyed it keeps throwing errors in the get function since 'windowEvents' is no longer in the attrs variable. Removing the window listeners when the destroy function is called fixes that. Great plugin! Cheers!

@LOK-Soft
Copy link

+1 for merging this

@LOK-Soft
Copy link

is included in pull request #70 with additional fixes

@Maximilianos
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants