Add HotManga source. #6992
Add HotManga source. #6992
Conversation
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class MangaDto( |
There was a problem hiding this comment.
| data class MangaDto( | |
| class MangaDto( |
There was a problem hiding this comment.
also remove unused fields
|
|
||
| class HotManga : ConfigurableSource, HttpSource() { | ||
|
|
||
| override val id = 2073023199372375753 |
There was a problem hiding this comment.
Why set this explicitly?
There was a problem hiding this comment.
The extension won't working if it's not specified.
There was a problem hiding this comment.
it would if you don't access the preference during class initialization, (namely for baseurl)
| .writeTimeout(15, TimeUnit.SECONDS).build() | ||
|
|
||
| override fun headersBuilder() = super.headersBuilder() | ||
| .set("Referer", baseUrl) |
There was a problem hiding this comment.
Referer header has a trailing slash.
| .set("Referer", baseUrl) | |
| .set("Referer", "$baseUrl/") |
| val url = "${baseUrl}$apiString".toHttpUrl().newBuilder() | ||
| return GET(url.build(), headers) |
There was a problem hiding this comment.
You can just pass a string to GET()
src/ru/hotmanga/src/eu/kanade/tachiyomi/extension/ru/hotmanga/HotManga.kt
Outdated
Show resolved
Hide resolved
src/ru/hotmanga/src/eu/kanade/tachiyomi/extension/ru/hotmanga/HotManga.kt
Outdated
Show resolved
Hide resolved
| return GET(url.build(), headers) | ||
| } | ||
|
|
||
| override fun fetchChapterList(manga: SManga): Observable<List<SChapter>> { |
There was a problem hiding this comment.
Avoid using the fetch* methods.
There was a problem hiding this comment.
Which method I should use instead?
There was a problem hiding this comment.
You should use the functions used in the parent fetch* methods, if the site structure allows it. So:
- Instead of
fetchPopularManga, you should usepopularMangaRequestandpopularMangaParse - Instead of
fetchSearchManga, you should usesearchMangaRequestandsearchMangaParse - Instead of
fetchLatestUpdates, you should uselatestUpdatesRequestandlatestUpdatesParse - Instead of
fetchMangaDetails, you should usemangaDetailsRequestandmangaDetailsParse - Instead of
fetchChapterList, you should usechapterListRequestandchapterListParse - Instead of
fetchPageList, you should usepageListRequestandpageListParse - Instead of
fetchImageUrl, you should useimageUrlRequestandimageUrlParse
There was a problem hiding this comment.
Ok, thanks. I'll rework it...
| chapterName += paidSymbol | ||
| } | ||
| val sChapter = SChapter.create().apply { | ||
| url = chapterUrl |
There was a problem hiding this comment.
Use setUrlWithoutDomain() to allow for easier domain swapping in the future.
src/ru/hotmanga/src/eu/kanade/tachiyomi/extension/ru/hotmanga/HotManga.kt
Outdated
Show resolved
Hide resolved
src/ru/hotmanga/src/eu/kanade/tachiyomi/extension/ru/hotmanga/HotManga.kt
Outdated
Show resolved
Hide resolved
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension