[skip ci] build only required modules #6900
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetleledaal
reviewed
Dec 29, 2024
| to_delete = json.loads(sys.argv[1]) | ||
|
|
||
| for module in to_delete: | ||
| apk_name = f"tachiyomi-{module}-v1.4.*.apk" |
There was a problem hiding this comment.
Suggested change
| apk_name = f"tachiyomi-{module}-v1.4.*.apk" | |
| apk_name = f"tachiyomi-{module}-v*.*.*.apk" |
| import json | ||
| import sys | ||
| from pathlib import Path | ||
| from typing import List, Tuple, Dict, Any |
There was a problem hiding this comment.
List, Tuple, and Dict can be replaced with list, tuple, and dict since Python 3.9, which is oldest version that is still supported.
|
|
||
| return list(modules), list(deleted) | ||
|
|
||
| def chunker(iterable: List[str], size: int) -> Dict[str, Any]: |
There was a problem hiding this comment.
Should replicate the signature of itertools.batched, the docs contain an implementation that can be used for Python <3.12.
There was a problem hiding this comment.
Further down you would use something like (can probably be formatted better):
chunked = {"chunk": [{"num": i, "modules": list(batch)} for i, batch in enumerate(batched(modules, int(os.getenv("CI_CHUNK_SIZE", 65))))]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs (more) testing and review