-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Novelfull #6823
base: main
Are you sure you want to change the base?
Add Novelfull #6823
Conversation
SelectFilterOption("爱情", "530"), | ||
), | ||
) | ||
// TODO: Automate this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need help here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could maybe have a list of tripple and build the list based on language/index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure for multiple languages, but you can use the selector: ul.nav > li:has(> a:containsOwn(Genre)) ul > li
with that you can get id and name kinda like this:
allGenres["en"] = document.select("ul.nav > li:has(> a:containsOwn(Genre)) ul > li > a").mapNotNull { element ->
val url = element.absUrl("href").toHttpUrlOrNull()
val id = url?.queryParameter("id")
id?.let { SelectFilterOption(element.ownText(), it) }
}
(code can be considered pseudo code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something called when the settings are called for the first time ? I remember to see a message like "Click on [Reset] to load genres" but I have no memories of this source, nor the function who is called.
OK I will check Mihon sources
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
SelectFilterOption("爱情", "530"), | ||
), | ||
) | ||
// TODO: Automate this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure for multiple languages, but you can use the selector: ul.nav > li:has(> a:containsOwn(Genre)) ul > li
with that you can get id and name kinda like this:
allGenres["en"] = document.select("ul.nav > li:has(> a:containsOwn(Genre)) ul > li > a").mapNotNull { element ->
val url = element.absUrl("href").toHttpUrlOrNull()
val id = url?.queryParameter("id")
id?.let { SelectFilterOption(element.ownText(), it) }
}
(code can be considered pseudo code)
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Outdated
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
src/all/novelfull/src/eu/kanade/tachiyomi/extension/all/novelfull/NovelFullGlobal.kt
Show resolved
Hide resolved
Co-authored-by: Vetle Ledaal <[email protected]>
Checklist:
overrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateweb_hi_res_512.png
when adding a new extensionClose #4486