[ru-Acomics] Fix parsing popular and search page #6611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AwkwardPeak7
requested changes
Dec 17, 2024
Comment on lines
+53
to
+55
| override fun popularMangaNextPageSelector(): String? { | ||
| TODO("Not yet implemented") | ||
| } |
There was a problem hiding this comment.
either throw UnsupportedOperationException on set to empty string
| popularMangaFromElement(element) | ||
| } | ||
|
|
||
| return MangasPage(mangas, true) |
There was a problem hiding this comment.
is there not some end page? maybe check number of entries on page and end page would have less.
vetleledaal
reviewed
Dec 18, 2024
| setUrlWithoutDomain(attr("href") + "/about") | ||
| title = text() | ||
| } | ||
| } | ||
|
|
||
| override fun popularMangaNextPageSelector() = "span.button:not(:has(a)) + span.button > a" | ||
| override fun popularMangaNextPageSelector(): String? { | ||
| TODO("Not yet implemented") |
There was a problem hiding this comment.
You are looking for a.infinite-scroll after the last div.infinite-scroll-content > section.serial-card. That element only exists if there is more content to load. You can make it as advanced or basic as you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extensionCloses #6120