Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config and messaging base of contracts #1

Merged
merged 18 commits into from
Feb 13, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Feb 6, 2024

  • issue # (WIP of blobstream L3 contract)
  • follows contribution guide
  • code change includes tests
  • breaking change

This PR aims at providing a base impl for appchain core contract on Starknet.

On-going tasks:

  • simple base contract (appchain.cairo)
  • configuration component
  • port messaging
  • complete messaging with cancelling
  • add first state update with tests without facts registry for messages

We will open issues once this is done for contributions and missing features.

README.md Outdated Show resolved Hide resolved
@glihm glihm marked this pull request as ready for review February 8, 2024 05:40
@glihm
Copy link
Collaborator Author

glihm commented Feb 8, 2024

@drspacemn I think we're good for a first PR and review before adding more stuff.

Next PR will be for rust bindings.
And after that we can check the state part. 👍

@glihm glihm requested a review from drspacemn February 8, 2024 05:41
Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For blobstream_starknet we include unit tests in the module and then the top level tests are for the contract logic itself. An example here would be:

tests/test_appchain.cairo
src/config/tests/test_config.cairo
src/messaging/tests/test_messaging.cairo

Thoughts on that structure?

src/appchain.cairo Outdated Show resolved Hide resolved
src/appchain.cairo Outdated Show resolved Hide resolved
tests/constants.cairo Outdated Show resolved Hide resolved
src/appchain.cairo Outdated Show resolved Hide resolved
src/config/component.cairo Show resolved Hide resolved
src/config/component.cairo Show resolved Hide resolved
Scarb.toml Show resolved Hide resolved
src/interface.cairo Show resolved Hide resolved
src/messaging/output_process.cairo Outdated Show resolved Hide resolved
@glihm glihm requested a review from drspacemn February 12, 2024 23:34
@glihm
Copy link
Collaborator Author

glihm commented Feb 13, 2024

@drspacemn ready for the second review.
Bumped to 2.5.3, even if OZ has some warnings pending.
Add some testing for appchain update_state function.

src/appchain.cairo Outdated Show resolved Hide resolved
@drspacemn drspacemn merged commit 15d5ce9 into keep-starknet-strange:main Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants