Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine CI jobs on push #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Combine CI jobs on push #103

wants to merge 3 commits into from

Conversation

nkuba
Copy link
Member

@nkuba nkuba commented Jan 13, 2021

In this PR we combined jobs happening on push to a repo. We extracted dependencies installation steps to a separate job that will be executed at the beginning and resolved node_modules will be used by all subsequent jobs.

We want just one `npm ci` job to happen so other jobs can use resolved
`node_modules` folder.
Moved node tests execution to one workflow so it is faster. We execute
just one `npm ci` to install dependencies and then use resolved
`node_modules` in all jobs.
@nkuba nkuba changed the base branch from npm-publish to master January 13, 2021 13:31
@pdyraga
Copy link
Member

pdyraga commented Nov 30, 2021

Hey @nkuba, is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants