-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearify confusing example #1403
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey, may I ask why you are changing this? I believe true is the default? |
@tomkerkhove Simply because it is confusing. The values and the comments don't match the example, |
0da944c
to
b2eaa5f
Compare
@tomkerkhove WDYT? |
Signed-off-by: Alon Gluz <[email protected]>
Signed-off-by: Alon Gluz <[email protected]>
b2eaa5f
to
2547b81
Compare
This is the criteria for disabling which is different from the default value though, which is true |
Provide a description of what has been changed
Checklist
Fixes #