Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor top-level search bar #1173

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Conversation

PixelRobots
Copy link
Contributor

@PixelRobots PixelRobots commented Jun 27, 2023

Provide a description of what has been changed

Update config.toml to change menu order as in #872

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@PixelRobots PixelRobots requested a review from a team as a code owner June 27, 2023 16:40
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit cefe4ea
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/649d319383282b0008f70e43
😎 Deploy Preview https://deploy-preview-1173--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove tomkerkhove changed the title #872 -rh chore: Refactor top-level search bar Jun 28, 2023
@tomkerkhove
Copy link
Member

Can you fix the DCO issues please? You can learn more in our contribution guide.

@tomkerkhove
Copy link
Member

@zroubalik @JorTurFer which one do you prefer?

  1. Abbreviated
    image

  2. Full
    image

PixelRobots and others added 5 commits June 29, 2023 08:12
Signed-off-by: PixelRobots <[email protected]>
Signed-off-by: PixelRobots <[email protected]>
Signed-off-by: PixelRobots <[email protected]>
Signed-off-by: PixelRobots <[email protected]>
@PixelRobots
Copy link
Contributor Author

Can you fix the DCO issues please? You can learn more in our contribution guide.

I think that fixed it.

@PixelRobots
Copy link
Contributor Author

@zroubalik @JorTurFer which one do you prefer?

  1. Abbreviated
    image
  2. Full
    image

The reason I chose Auth providers is due to the button on the homepage being "Auth providers"

@JorTurFer
Copy link
Member

As now it'll be a top level button, I prefer it shorter as possible to not taking all the screen just for a button

@tomkerkhove
Copy link
Member

Thanks a ton!

@tomkerkhove tomkerkhove merged commit 08b5e03 into kedacore:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants