added 3 tests to improve coverage #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes our existing mnemonic_generation.oy accessible as an interactive CLI utility for converting dice rolls or coin flips into 12- or 24-word mnemonics as well as the final word calculation. * Reduces python dependencies in mnemonic_generation.py * Removes need to always specify `wordlist_language_code`. * Adds constants for number of dice rolls for each mnemonic phrase length (since 99 may become 100 soon). * Generates test dice rolls, coin flips, or word selections via its "rand12" and "rand24" option. * Adds support for coin flips, even though the SeedSigner UI does not support coin flips yet (and might not ever). * Updates dice_verification.md accordingly.
kdmukai
force-pushed
the
entropy_to_mnemonic_cli
branch
3 times, most recently
from
3bca811 to
fe55ccd
Compare
kdmukai
force-pushed
the
entropy_to_mnemonic_cli
branch
from
fe55ccd to
fe9c248
Compare
kdmukai
force-pushed
the
entropy_to_mnemonic_cli
branch
from
3addd5c to
1ed703b
Compare
kdmukai
pushed a commit
that referenced
this pull request
Oct 2, 2024
Readme file updates- Changes to the verification section (to use keybase.io), clarify the steps thereof, and various other minor edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that with a few more tests, that coverage for this module would be brought up to 100%... except the whole cli section which gets excluded.
Trying to follow your good example, code and tests in the same pr... That caught me off guard, it's going to be a habit worth taking.