Adds serviceaccounts,secrets and configmaps GVRs to the default Syncer sync list #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jmprusi
force-pushed
the
jmprusi-syncer-sync-configmaps-serviceaccounts
branch
from
d394699
to
8252223
Compare
jmprusi
changed the title
sttts
reviewed
Mar 11, 2022
| @@ -176,7 +176,7 @@ func getAllGVRs(discoveryClient discovery.DiscoveryInterface, resourcesToSync .. | |||
| return nil, err | |||
| } | |||
| } | |||
| gvrstrs := []string{"namespaces.v1."} // A syncer should always watch namespaces | |||
| gvrstrs := []string{"namespaces.v1.", "serviceaccounts.v1.", "configmaps.v1.", "secrets.v1."} // A syncer should always watch namespaces, serviceaccounts, secrets and configmaps. | |||
There was a problem hiding this comment.
does this also mean they are synced by default?
There was a problem hiding this comment.
Yes... But we can tune the scheduler to avoid that.
There was a problem hiding this comment.
@sttts I've pushed a WIP commit, trying to solve that issue, let me know what you think
There was a problem hiding this comment.
as we discussed on slack, I've dropped those changes, and let's assume for now, that we sync everything by default.
There was a problem hiding this comment.
Pushing the default syncing discussion into Prototype4 https://github.com/kcp-dev/kcp/issues/727
jmprusi
changed the title
jmprusi
force-pushed
the
jmprusi-syncer-sync-configmaps-serviceaccounts
branch
2 times, most recently
from
8124ae8
to
a48b537
Compare
jmprusi
changed the title
jmprusi
force-pushed
the
jmprusi-syncer-sync-configmaps-serviceaccounts
branch
3 times, most recently
from
1a48143
to
5042497
Compare
jmprusi
force-pushed
the
jmprusi-syncer-sync-configmaps-serviceaccounts
branch
2 times, most recently
from
baf4ceb
to
34e0dcf
Compare
sttts
approved these changes
Mar 16, 2022
kcp-ci-bot
added
the
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the default Sync list of the syncer, the GVRs of:
This means, that even if not specified via API imports, or "resources-to-sync" args, the syncer will sync those resources to the workloadclusters.
Pushing the discussion on how to improve the default syncing into Prototype4: kcp-dev/contrib-tmc#137
This is related to: #280