✨ Enable webhook authorization options #3198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/L
kcp-ci-bot
added
the
do-not-merge/work-in-progress
|
/test all |
…ing legacy-cloud-providers dependency On-behalf-of: @SAP [email protected]
|
/test all |
…e kcp options On-behalf-of: @SAP [email protected]
|
/test all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows to configure an external webhook for authorization. Previously the relevant flags have been explicitly disabled in kcp, because kcp has its own authorizer. The webhook authorizer would sit next to the existing authorizers (allowPath, allowGroup) and so is an alternative to the built-in authorizers.
Since I only implemented and tested the webhook mode, I did not surface the
--authorization-modeflag, but instead set this value based on the presence of the other webhook related flags.This PR also includes a dependency bump to include kcp-dev/kubernetes#151, which will take care of including the cluster name in the webhook's payload. In that dependency bump is also, slightly hidden, a cleanup for the
bump-k8sscript, which failed at least since the 1.31 bump since thelegacy-cloud-providersmodule doesn't exist anymore.Lastly, I removed the custom Authentication setup logic, as what we did here was exactly the same as upstream code already does and it simply seemed redundant.
Release Notes