Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Organize generated CRD documentation by API group #3110

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

embik
Copy link
Member

@embik embik commented Apr 4, 2024

Summary

The generated CRD documentation is a flat list, which includes all kcp APIs. This PR post-processes the output of https://github.com/giantswarm/crd-docs-generator (I couldn't find an option to split by API group; might be worth upstreaming such a change) and puts each API group in its own folder, providing a more organised CRD documentaiton experience:

Screenshot 2024-04-04 at 10 56 05

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2024
@embik
Copy link
Member Author

embik commented Apr 4, 2024

/cc @xrstf @sttts

@kcp-ci-bot kcp-ci-bot requested review from sttts and xrstf April 4, 2024 08:56
@sttts
Copy link
Member

sttts commented Apr 4, 2024

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ab45d7c7240f9427135820c97e1f5a56bdb177a

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@kcp-ci-bot kcp-ci-bot merged commit 2054dbf into kcp-dev:main Apr 4, 2024
14 checks passed
@embik embik deleted the crd-ref-gen-update branch April 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants