Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 make help #3005

Merged
merged 1 commit into from
Sep 12, 2023
Merged

🐛 make help #3005

merged 1 commit into from
Sep 12, 2023

Conversation

carlory
Copy link
Contributor

@carlory carlory commented Sep 12, 2023

Summary

(⎈|kind-kind:N/A)➜  kcp git:(main) make help
Makefile                       Build the project
Makefile                       Show this help.
Makefile                       Install the project
Makefile                       Run go mod tidy to ensure modules are up to date
Makefile                       Vendor the dependencies
Makefile                       Verify go modules are up to date

with this change:

(⎈|kind-kind:N/A)➜  kcp git:(makefile) make help
build                          Build the project
clean-workdir                  Clean workdir
clean                          Clean all
codegen                        Generate all
crds                           Generate crds
deploy-docs                    Deploy docs
download-e2e-logs              Download e2e logs from a given URL
generate-api-docs              Generate api docs
generate-cli-docs              Generate cli docs
help                           Show this help
install                        Install the project
lint                           Verify lint
modules                        Run go mod tidy to ensure modules are up to date
serve-docs                     Serve docs
test-e2e                       Run e2e tests
test                           Run tests
tools                          Install tools
update-contextual-logging      Update contextual logging
vendor                         Vendor the dependencies
verify-boilerplate             Verify boilerplate
verify-codegen                 Verify codegen
verify-go-versions             Verify go versions
verify-imports                 Verify imports
verify-k8s-deps                Verify kubernetes deps
verify-modules                 Verify go modules are up to date

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@kcp-ci-bot
Copy link
Contributor

Hi @carlory. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: carlory <[email protected]>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Sep 12, 2023
@carlory carlory changed the title 🐛 🐛 make help :bug make help Sep 12, 2023
@carlory carlory changed the title :bug make help 🐛 make help Sep 12, 2023
@mjudeikis
Copy link
Contributor

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@carlory
Copy link
Contributor Author

carlory commented Sep 12, 2023

/test pull-kcp-lint

@carlory
Copy link
Contributor Author

carlory commented Sep 12, 2023

/test pull-kcp-test-e2e-shared
/test pull-kcp-test-e2e-sharded

@carlory
Copy link
Contributor Author

carlory commented Sep 12, 2023

/test pull-kcp-test-e2e-shared

@sttts
Copy link
Member

sttts commented Sep 12, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e9f14c767a4530d601989e922e9a2f7360493ec

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@kcp-ci-bot kcp-ci-bot merged commit bb5ce8f into kcp-dev:main Sep 12, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants