Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Disable leader election, too much noise in log #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincent-pli
Copy link
Contributor

The interval is 2 sec, too much noise in the log of controller, and there is only one replicate, no need for leader election

I0923 04:20:33.632567       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 19 milliseconds
I0923 04:20:33.632990       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:35.658947       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 24 milliseconds
I0923 04:20:35.671078       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 11 milliseconds
I0923 04:20:35.671417       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:37.686726       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 14 milliseconds
I0923 04:20:37.702415       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 15 milliseconds
I0923 04:20:37.702734       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:39.713474       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 10 milliseconds
I0923 04:20:39.729839       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 13 milliseconds
I0923 04:20:39.730254       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:41.754042       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 22 milliseconds
I0923 04:20:41.785280       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 30 milliseconds
I0923 04:20:41.785645       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:43.801143       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 14 milliseconds
I0923 04:20:43.810940       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 9 milliseconds
I0923 04:20:43.811259       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain
I0923 04:20:45.832623       1 round_trippers.go:553] GET https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 20 milliseconds
I0923 04:20:45.844730       1 round_trippers.go:553] PUT https://172.16.251.127:6443/apis/coordination.k8s.io/v1/namespaces/controller-runtime-example-system/leases/68a0532d.my.domain 200 OK in 11 milliseconds
I0923 04:20:45.845134       1 leaderelection.go:278] successfully renewed lease controller-runtime-example-system/68a0532d.my.domain

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an extensive example where we are dealing with multiple replicas, disabling LE should be fine.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: varshaprasad96, vincent-pli
Once this PR has been reviewed and has the lgtm label, please assign davidfestal for approval by writing /assign @davidfestal in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

@vincent-pli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 6ee11e3 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Member

ncdc commented Jan 29, 2024

/uncc

@kcp-ci-bot kcp-ci-bot removed the request for review from ncdc January 29, 2024 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants