Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KCL Go AST definition and parser API #408

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: KCL Go AST definition and parser API

Closes #405
Refs #404

@Peefy Peefy force-pushed the feat-parse-file-ast branch from 35670ba to 43b66cb Compare November 18, 2024 08:37
@Peefy
Copy link
Contributor Author

Peefy commented Nov 18, 2024

@witcxc Can you help review it and see if it is suitable for your scenario?

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11888674741

Details

  • 546 of 1844 (29.61%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 36.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/parser/parser.go 7 11 63.64%
pkg/ast/type.go 0 12 0.0%
pkg/ast/stmt.go 0 72 0.0%
pkg/ast/expr.go 0 196 0.0%
pkg/ast/op.go 11 314 3.5%
pkg/ast/json.go 523 1234 42.38%
Totals Coverage Status
Change from base Build 11886554522: -0.9%
Covered Lines: 5448
Relevant Lines: 15007

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 46125a9 into main Nov 18, 2024
21 checks passed
@Peefy Peefy deleted the feat-parse-file-ast branch November 18, 2024 08:52
@Peefy Peefy mentioned this pull request Nov 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL AST Definitions for Go SDK support Go API for GetSchemaTypeMapping
4 participants