Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native): ✨ add RunPaths #344

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ghostsquad
Copy link
Contributor

allows users to easily specify multiple files, like how the KCL CLI allows specifying multiple files.

ref: https://www.kcl-lang.io/docs/next/reference/lang/tour#multi-file-compilation

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix kcl-lang/kcl#1466

2. What is the scope of this PR (e.g. component or file name):

/pkg/native/api

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Allows users to pass in multiple paths, like how the CLI behaves. Ref: https://www.kcl-lang.io/docs/next/reference/lang/tour#multi-file-compilation

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

see /pkg/native/api_test.go

Copy link

github-actions bot commented Jul 3, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

allows users to easily specify multiple files, like how the KCL CLI allows specifying multiple files.

ref: https://www.kcl-lang.io/docs/next/reference/lang/tour#multi-file-compilation
@ghostsquad ghostsquad force-pushed the feat/add-native-runpaths branch from 295a1b6 to d6b4382 Compare July 3, 2024 05:37
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9772463701

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 32.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/native/api.go 7 8 87.5%
Totals Coverage Status
Change from base Build 9739398846: 0.03%
Covered Lines: 5653
Relevant Lines: 17171

💛 - Coveralls

@Peefy Peefy merged commit a34da40 into kcl-lang:main Jul 3, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export native.run as RunPaths support Go API for GetSchemaTypeMapping
3 participants