Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: system modules #236

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: system modules #236

merged 1 commit into from
Feb 19, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: system modules

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <[email protected]>
@Peefy Peefy force-pushed the fix-system-modules branch from d215e08 to d5785e1 Compare February 19, 2024 13:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7960184216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.186%

Totals Coverage Status
Change from base Build 7955071588: 0.0%
Covered Lines: 3038
Relevant Lines: 4808

💛 - Coveralls

@Peefy Peefy merged commit e5e87bd into kcl-lang:main Feb 19, 2024
7 checks passed
@Peefy Peefy deleted the fix-system-modules branch February 19, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
2 participants