Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go plugin APIs and examples #233

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: add go plugin APIs and examples

2. What is the scope of this PR (e.g. component or file name):

  • pkg/native/**

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • examples/plugin/main.go
  • pkg/native/api_test.go
  • pkg/native/client_test.go

Sorry, something went wrong.

@Peefy Peefy force-pushed the feat-kcl-go-plugin branch from a413c7d to 4fe07e0 Compare February 19, 2024 03:36
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy force-pushed the feat-kcl-go-plugin branch from e8eb3aa to 9a118b6 Compare February 22, 2024 06:21
@coveralls
Copy link

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8001919370

Details

  • -50 of 173 (71.1%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 63.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm.go 0 2 0.0%
pkg/kcl/api.go 14 16 87.5%
pkg/plugin/plugin.go 0 4 0.0%
pkg/native/api.go 14 19 73.68%
pkg/native/loader.go 16 22 72.73%
pkg/native/cgo.go 21 32 65.63%
pkg/native/client.go 43 63 68.25%
Files with Coverage Reduction New Missed Lines %
pkg/kcl/api.go 1 48.4%
Totals Coverage Status
Change from base Build 8000238102: 0.3%
Covered Lines: 3127
Relevant Lines: 4943

💛 - Coveralls

@Peefy Peefy force-pushed the feat-kcl-go-plugin branch 3 times, most recently from 993365d to d52356d Compare February 22, 2024 08:50
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the feat-kcl-go-plugin branch from d52356d to 30ad26d Compare February 22, 2024 09:02
@Peefy Peefy merged commit 45b5847 into kcl-lang:main Feb 22, 2024
7 checks passed
@Peefy Peefy deleted the feat-kcl-go-plugin branch February 22, 2024 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants