Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl kcl config generation and add indent block for JSON/YAML inputs #209

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #204

2. What is the scope of this PR (e.g. component or file name):

  • pkg/tools/gen/genkcl_json.go
  • pkg/tools/gen/genkcl_yaml.go
  • pkg/tools/gen/template.go
  • pkg/tools/gen/testdata/json/**
  • pkg/tools/gen/testdata/yaml/**

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added the tool label Jan 14, 2024
@Peefy Peefy requested a review from jakezhu9 January 14, 2024 07:29
@Peefy Peefy added the gen label Jan 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7517751205

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 62.892%

Totals Coverage Status
Change from base Build 7517369434: 0.04%
Covered Lines: 2905
Relevant Lines: 4619

💛 - Coveralls

Copy link
Contributor

@jakezhu9 jakezhu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@jakezhu9 jakezhu9 merged commit 11a8a42 into kcl-lang:main Jan 14, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants