Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a field 'result' to get the result whose type is not []KCLRe… #201

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

zong-zhe
Copy link
Contributor

…sult

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #193

2. What is the scope of this PR (e.g. component or file name):

kcl run

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Dec 21, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy December 21, 2023 06:53
@zong-zhe zong-zhe self-assigned this Dec 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7284969938

  • 2 of 75 (2.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 62.981%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/api.go 2 75 2.67%
Totals Coverage Status
Change from base Build 7245738269: -1.0%
Covered Lines: 2780
Relevant Lines: 4414

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ccb9398 into kcl-lang:main Dec 21, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

Bug: using the --selector may result in a compilation error support Go API for GetSchemaTypeMapping
3 participants