Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate schema for nested object in array #197

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jakezhu9
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references

  • N
  • Y

fix #195

2. What is the scope of this PR (e.g. component or file name):

pkg/tools/gen

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Fix the issue of missing schema for nested objects in an array when generating KCL from a JSON schema.
To achieve this, we add paths information to the convertContext and use full path as the name of the nested object schema.
It also fixes a potential issue where the generated schema could be wrong when the names of nested object are the same, as now they will have there own unique name.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7179073979

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 63.973%

Totals Coverage Status
Change from base Build 7156094195: 0.1%
Covered Lines: 2779
Relevant Lines: 4344

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM! ❤️

@Peefy Peefy merged commit dfe255f into kcl-lang:main Dec 12, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error JsonSchema import output
3 participants