fix: generate schema for nested object in array #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references
fix #195
2. What is the scope of this PR (e.g. component or file name):
pkg/tools/gen
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Fix the issue of missing schema for nested objects in an array when generating KCL from a JSON schema.
To achieve this, we add paths information to the convertContext and use full path as the name of the nested object schema.
It also fixes a potential issue where the generated schema could be wrong when the names of nested object are the same, as now they will have there own unique name.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: