Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use triple quote for raw or escaped string #196

Merged
merged 3 commits into from
Dec 10, 2023

Conversation

jakezhu9
Copy link
Contributor

@jakezhu9 jakezhu9 commented Dec 8, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: kcl-lang/kcl#947

2. What is the scope of this PR (e.g. component or file name):

pkg/tools/gen

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

use r"""xxxxxx""" for raw or escaped string and add real world test cases for it (github workflow, k8s, goreleaser)

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

coveralls commented Dec 8, 2023

Pull Request Test Coverage Report for Build 7140035590

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 63.875%

Totals Coverage Status
Change from base Build 7124985066: 0.3%
Covered Lines: 2769
Relevant Lines: 4335

💛 - Coveralls

@jakezhu9
Copy link
Contributor Author

jakezhu9 commented Dec 8, 2023

Not quite sure why it will fail in CI. On my computer (windows 10), all test pass. I will investigate further later

@amyXia1994
Copy link
Contributor

lgtm

@Peefy
Copy link
Contributor

Peefy commented Dec 10, 2023

Good Job! LGTM

@Peefy Peefy merged commit 2c72167 into kcl-lang:main Dec 10, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kcl import will generate invalid file support Go API for GetSchemaTypeMapping
4 participants