-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add api 'GetFullSchemaType' to support external package in kcl doc #188
Conversation
Signed-off-by: zongz <[email protected]>
cc @zong-zhe, I have upgrade the kcl artifact to v0.7.0-beta.2 and check passed. Ref: After this PR has been merged, we can trigger a kcl-go v0.7.0-beta.2 tag for kpm. Then we can trigger a 0.5.0 kpm tag for kcl-go. After all, the v0.7.0 kcl-go tag release! |
Signed-off-by: zongz <[email protected]>
Pull Request Test Coverage Report for Build 7043204534Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Signed-off-by: zongz <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: zongz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
pkg/kcl/api.go
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: