Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message and exit after doc cmd validation error #158

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

cmds/kcl-go/command/cmd_doc.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix bug: the kcl-go doc command does not exit directly after validating command line argument failed.

this PR fixes the bug, show error message and exit after doc cmd validation error

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested a review from Peefy September 14, 2023 08:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6182882240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.677%

Totals Coverage Status
Change from base Build 6157732069: 0.0%
Covered Lines: 2611
Relevant Lines: 4037

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 772e457 into kcl-lang:main Sep 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
@amyXia1994 amyXia1994 deleted the fix/doc-gen-validation-error branch September 15, 2023 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants