Remove unnecessary config check for BuildCallToCustomDerivativeOrNume…

…ricalDiff
kchristin22 · Oct 11, 2024 · 8c848de · 8c848de
1 parent 215d949
commit 8c848de
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 20 deletions.
diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -2657,16 +2657,11 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
       NumDiffArgs.push_back(args[i]);
     }
     std::string Name = "central_difference";
-    return config ? m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
-                        Name, NumDiffArgs, getCurrentScope(),
-                        /*OriginalFnDC=*/nullptr,
-                        /*forCustomDerv=*/false,
-                        /*namespaceShouldExist=*/false, config)
-                  : m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
-                        Name, NumDiffArgs, getCurrentScope(),
-                        /*OriginalFnDC=*/nullptr,
-                        /*forCustomDerv=*/false,
-                        /*namespaceShouldExist=*/false);
+    return m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
+        Name, NumDiffArgs, getCurrentScope(),
+        /*OriginalFnDC=*/nullptr,
+        /*forCustomDerv=*/false,
+        /*namespaceShouldExist=*/false, config);
   }
 
   StmtDiff ReverseModeVisitor::VisitUnaryOperator(const UnaryOperator* UnOp) {

diff --git a/lib/Differentiator/VisitorBase.cpp b/lib/Differentiator/VisitorBase.cpp
@@ -756,16 +756,11 @@ namespace clad {
     NumDiffArgs.insert(NumDiffArgs.end(), args.begin(), args.begin() + numArgs);
     // Return the found overload.
     std::string Name = "forward_central_difference";
-    return config ? m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
-                        Name, NumDiffArgs, getCurrentScope(),
-                        /*OriginalFnDC=*/nullptr,
-                        /*forCustomDerv=*/false,
-                        /*namespaceShouldExist=*/false, config)
-                  : m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
-                        Name, NumDiffArgs, getCurrentScope(),
-                        /*OriginalFnDC=*/nullptr,
-                        /*forCustomDerv=*/false,
-                        /*namespaceShouldExist=*/false);
+    return m_Builder.BuildCallToCustomDerivativeOrNumericalDiff(
+        Name, NumDiffArgs, getCurrentScope(),
+        /*OriginalFnDC=*/nullptr,
+        /*forCustomDerv=*/false,
+        /*namespaceShouldExist=*/false, config);
   }
 
   void VisitorBase::CallExprDiffDiagnostics(const clang::FunctionDecl* FD,