Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upd] Add better authentication for RDF4jModule #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Matthew-Kulich
Copy link
Contributor

Related to this #29 .

@Matthew-Kulich Matthew-Kulich requested a review from blcham January 24, 2023 10:24
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to implement it little different way.

Have a module with param like following:
:m rdf4j-module:p-rdf4j-secured-username-variable "uclUsername"
:m rdf4j-module:p-rdf4j-secured-password-variable "uclPassword"

And then have config-core.properties providing those variables as you implemented, i.e.
variable.assignment.uclUsername=heslo-ucl
variable.assignment.uclPassword=heslo-ucl

And having ConfigCoreProperties some method that return those variables, e.g.:
Map<String, String> getConfigurationVariables()-- but i would trim "variable.assignment" part out of it.

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, have a look at my last review, I think we did not understand each other, sorry for that.

I was expecting this module to have new parameter called p-rdf4j-secured-username-variable, i.e. I was expecting that I will find out following code:

    static final Property P_RDF4J_REPOSITORY_NAME = getParameter("p-rdf4j-secured-username-variable");
    private String rdf4jSecuredUsernameVariable;

@Matthew-Kulich
Copy link
Contributor Author

Matthew-Kulich commented Feb 16, 2023

The simple solution is implemented and merged here #146.

This PR will be finished later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants