Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/276 sparql annotation as list #289

Merged

Conversation

luxbe
Copy link
Contributor

@luxbe luxbe commented Nov 21, 2024

Fixes #276 by treating Collections as Lists instead of Sets by default

@luxbe luxbe force-pushed the feature/276-sparql-annotation-as-list branch from 90952da to 4899f6f Compare November 21, 2024 14:21
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this tomorrow, I am not sure your change addresses only the referenced issue.
It also seems to me there are changes already done in other PRs (like the OWLClassV), so probably the changes need to be rebased on development.

@luxbe luxbe force-pushed the feature/276-sparql-annotation-as-list branch from 4899f6f to 1a46545 Compare November 22, 2024 11:31
@luxbe luxbe force-pushed the feature/276-sparql-annotation-as-list branch from 1a46545 to 7e2f4d0 Compare November 22, 2024 11:33
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledsoft ledsoft merged commit f8fbfe1 into kbss-cvut:development Nov 22, 2024
1 check passed
@ledsoft ledsoft linked an issue Nov 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lists for plural fields populated by SPARQL queries by default
2 participants