refactor: page title を page component に移動

kasaharu · Feb 12, 2024 · 9990885 · 9990885
1 parent 7bfed66
commit 9990885
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/src/app/features/top/containers/top/top.component.html b/src/app/features/top/containers/top/top.component.html
@@ -1,5 +1,3 @@
-<app-page-title [title]="name"></app-page-title>
-
 <div class="contents">
   <img src="assets/images/profile.jpg" width="200" height="200" alt="" />
 

diff --git a/src/app/features/top/containers/top/top.component.ts b/src/app/features/top/containers/top/top.component.ts
@@ -1,8 +1,8 @@
-import { ChangeDetectionStrategy, Component } from '@angular/core';
 import { NgFor } from '@angular/common';
-import { snsList } from '../../data/sns';
+import { ChangeDetectionStrategy, Component } from '@angular/core';
 import { ExternalLinkDirective } from '../../../../shared/external-link/directives/external-link.directive';
 import { PageTitleComponent } from '../../../../shared/page-title/page-title/page-title.component';
+import { snsList } from '../../data/sns';
 
 @Component({
   selector: 'app-top',
@@ -13,7 +13,6 @@ import { PageTitleComponent } from '../../../../shared/page-title/page-title/pag
   imports: [PageTitleComponent, NgFor, ExternalLinkDirective],
 })
 export class TopComponent {
-  readonly name = 'kasaharu (Wataru KASAHARA)';
   readonly myInfoList: string[] = ['Web Frontend Engineer', 'Angular Japan User Group Staff'];
   readonly snsList = snsList;
 }
diff --git a/src/app/features/top/top.component.ts b/src/app/features/top/top.component.ts
@@ -1,10 +1,16 @@
 import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { PageTitleComponent } from '../../shared/page-title/page-title/page-title.component';
 import { TopComponent } from './containers/top/top.component';
 
 @Component({
-  template: '<app-top></app-top>',
+  template: `
+    <app-page-title [title]="name"></app-page-title>
+    <app-top></app-top>
+  `,
   changeDetection: ChangeDetectionStrategy.OnPush,
   standalone: true,
-  imports: [TopComponent],
+  imports: [TopComponent, PageTitleComponent],
 })
-export class TopPageComponent {}
+export class TopPageComponent {
+  readonly name = 'kasaharu (Wataru KASAHARA)';
+}