Issue3288 dx coil heating #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved memory allocation * corrected html syntax
* Fix reverse acting * Update reference results * Update revisions and release notes
* Corrected CDL conformance For #3301 * Redirected documentation of MSL classes to doc.modelica.org * Redirected documentation of MSL classes to doc.modelica.org * Updated url to https
Added package Fluid.HydronicConfigurations --------- Co-authored-by: David Blum <[email protected]> Co-authored-by: Michael Wetter <[email protected]>
* improved validation models * changed the initial value to avoid difference results between dymola and omc * Tightened tolerance of reference results, enabled result verification This enables result verification with OpenModelica for the OBC.CDL package * Tightened tolerance --------- Co-authored-by: Michael Wetter <[email protected]>
* Added example for air heat and mass balance.
* corrected implementation and updated references --------- Co-authored-by: Michael Wetter <[email protected]>
* copied Obsolete.Fluid.Movers from IBPSA * corrected constrainedby clause for OCT warning * deleted Nrpm component in HydronicConfigurations * renamed speed in enum
* Renamed AirCooled to AirSource, and same for WaterCooled For #3288 * Restructure the DX coil package to implement the DX heating coil * Modify the other models that are impacted by the structure change
* correcting the nominal conditions * corrected assert condition
* add Logical.VariablePulse
* added chiller plant controller namings, #819 [ci skip]
* moved PID controller instance to public section * improved instance names
* adding proof block
* Renamed CDL.Continuous.Sources.Sine to Sin For #3339 * Updated revision notes and image path
This sets the start value for NTUAirSta
X is not available on the weather data bus
This allows the record to be replaced by models that extend this model
This separates the base classes to those used for heating, cooling, or both
* fixed links in Buildings.Fluid.Geothermal * Fluid.HydronicConfigurations.ActiveNetworks Buildings/Fluid/HydronicConfigurations/ActiveNetworks/Examples$ sed -i 's/Buildings.Fluid.HydronicConfigurations.Examples.BaseClasses.Load/Buildings.Fluid.HydronicConfigurations.ActiveNetworks.Examples.BaseClasses.Load/g' $(find . -iname '*.mo') * removed links The links could not be resolved because they lead to constants instead of classes. * Obsolete.Fluid.Movers.Data
This integrates IBPSA 1762. This corrects the variability as assigning an input to a parameter is not allowed
This improves the documentation
* Moved data record for heating coil validation from cooling subpackage to heating subpackage * Updated documentation with calculations from EPlus engineering reference. Updated parameter comments * Created individual user guides for heating and cooling DX coils from common user guide * Updated documentation with reference to heating coil * Updated parameter on input interface * Updated package.order files * Updated EPlus files from version 22.2 to 23.1 * Removed unused parameter assignment
This avoids a warning in Optimica as the heat port may not be present in all plug compatible models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.