Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue3438_DXdehumidifier #120

Open
wants to merge 56 commits into
base: issue3438_DXdehumidifier_mergeFix
Choose a base branch
from
Open

Issue3438_DXdehumidifier #120

wants to merge 56 commits into from

Conversation

lzwang26
Copy link

@lzwang26 lzwang26 commented Feb 9, 2024

Address the comments.

terrancelu92 and others added 30 commits August 24, 2023 09:28
@terrancelu92
Change the version to v96
11d1425
@karthikeyad-pnnl
Added new argument to DAT generation script for start time of DAT file
cc18bb7
@karthikeyad-pnnl
Merge pull request karthikeyad-pnnl#82 from lbl-srg/issue3438_DXdehum…
b439e11 
…idifier

Issue3438 d xdehumidifier
@karthikeyad-pnnl
Merge pull request karthikeyad-pnnl#83 from karthikeyad-pnnl/issue348…
eaa4c78 
…4_DATGenerationUpdate

Issue3484 dat generation update
@karthikeyad-pnnl
Implemented fixes to DAT generation script
609a886
@terrancelu92
Modify the initialization time for the case
c44aa1a
@terrancelu92
Merge pull request karthikeyad-pnnl#8 from karthikeyad-pnnl/issue3438…
531d806 
…_DXdehumidifier

Issue3438 d xdehumidifier
@terrancelu92
Add starttime argument to generate the dat file
69b15f5
@terrancelu92
Add open loop validation case
0cb5123
@terrancelu92
Debug DXDehumidifier open loop testing
99912f7
@karthikeyad-pnnl
Merge pull request karthikeyad-pnnl#84 from terrancelu92/issue3438_DX…
9c6279d 
…dehumidifier

Debug DXDehumidifier open loop testing
@karthikeyad-pnnl
Backing up debugging exercise for DX dehumidifier
1a49b08
@terrancelu92
Added the open loop validation case and enhanced the documentation
10492d1
@terrancelu92
Delete the closed loop validation case and add the delay time paramet…
33b47d9 
…er in PLRtoPulse module
@terrancelu92
Add results changed from the unit test
3049754
@karthikeyad-pnnl
Merge branch 'issue3438_DXdehumidifier' of github.com:terrancelu92/mo…
6f22f02 
…delica-buildings into issue3438_DXdehumidifier_Xing_repo
@karthikeyad-pnnl
Merge branch 'issue3438_DXdehumidifier_Xing_repo' into issue3438_DXde…
5ebc607 
…humidifier
@karthikeyad-pnnl
Removed unused models
ab0c495
@karthikeyad-pnnl
Removed unused mos script
9237db3
@terrancelu92
Merge remote-tracking branch 'lbl-srg/modelica-buildings/master' into…
4d2bcce 
… issue3438_DXdehumidifier
@terrancelu92
Addressed most of comments from Jianjun
2e4b2bf
@terrancelu92
Revert "Merge remote-tracking branch 'lbl-srg/modelica-buildings/mast…
61b7480 
…er' into issue3438_DXdehumidifier"

This reverts commit 4d2bcce, reversing
changes made to 9237db3.
@karthikeyad-pnnl
Merge pull request karthikeyad-pnnl#106 from terrancelu92/issue3438_D…
409e799 
…Xdehumidifier

Issue3438 d xdehumidifier
@karthikeyad-pnnl
Replaced html tags with font info with code tags
b53b1d4
@karthikeyad-pnnl
Removed redundant if-else condition from equation section. Corrected …
7b1a70d 
…subplot numbers in validation script
@karthikeyad-pnnl
Simplified equations and calculations for water removal rate and powe…
f820838 
…r consumption. Updated comments
@karthikeyad-pnnl
Updated documentation section formatting
314c17c
@karthikeyad-pnnl
Added alternative calculation for power consumption using CDL blocks
a857a9b
@karthikeyad-pnnl
Removed redundant calculation blocks
ea782b5
@karthikeyad-pnnl
Merge branch 'issue3438_DXdehumidifier' of github.com:lbl-srg/modelic…
a5702c9 
…a-buildings into lbl-srg-issue3438_DXdehumidifier
karthikeyad-pnnl and others added 26 commits November 29, 2023 17:18
@karthikeyad-pnnl
Merge branch 'lbl-srg-issue3438_DXdehumidifier' into issue3438_DXdehu…
c5fca39 
…midifier
@karthikeyad-pnnl
Added missing package in package order file
0ac6da2
@karthikeyad-pnnl
Updated documentation and formatting
c620bbc
@karthikeyad-pnnl
Merge pull request karthikeyad-pnnl#108 from lbl-srg/issue3438_DXdehu…
40a51a3 
…midifier

Issue3438 d xdehumidifier
@lzwang26
Delete displayUnit = 'w' in DXDehumidifier.mo
71884fd
@lzwang26
Move the package Medium after the extends in Validation.DXDehumidifie…
06b4be2 
…r.mo
@lzwang26
Modify the name convention Validation.DXDehumidifier.mo
dbef3b0
@lzwang26
Modify the name convention
faded54
@lzwang26
Change instance names
b22c12e
@lzwang26
Update reference data for unit tests.
75237fe
@lzwang26
Created a BaseClasses package for humidifiers
9bc561c
@lzwang26
Add baseclass WaterRemovalModifierCurve
bdeb363
@lzwang26
Some changes
7ba2a9a
@lzwang26
Revert "Some changes"
48d2384 
This reverts commit 7ba2a9a.
@lzwang26
Add some changes
41e2ed3
@karthikeyad-pnnl
Split single file into multiple directories and files
c59e682
@karthikeyad-pnnl
Added parameter keyword to data record
5fb135c
@lzwang26
Merge pull request #4 from karthikeyad-pnnl/issue3544_HeatPumpRTUCont…
cec54b0 
…rols_LingzheRepo

Issue3544 heat pump rtu controls lingzhe repo
@lzwang26
Combined water and energy curve to one.
fe9d87d
@lzwang26
Add energy factor modifier in Modifier Curve
e3fedb8
@lzwang26
Modify DXDehumidier to use the Modifier Curve
f12a9cd
@lzwang26
Add documentations for the models
832de41
@lzwang26
Delete the DXDehumidifier Example
42f765a
@lzwang26
Delete the example of the curve modifier
1b6c34a
@lzwang26
Modify the documentation of DXHeating PLRToPulse
8b93901
@lzwang26
Delete Baseclass example folder
3240d86
@karthikeyad-pnnl karthikeyad-pnnl changed the base branch from issue3438_DXdehumidifier to issue3438_DXdehumidifier_mergeFix April 8, 2024 02:38
karthikeyad-pnnl added a commit that referenced this pull request Apr 8, 2024
@karthikeyad-pnnl
Imported only required changes from #120
55140dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzwang26 @terrancelu92 @karthikeyad-pnnl