Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce StatePreservation to PropagationPolicy API #5885

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Nov 26, 2024

What type of PR is this?

/kind api-change
/kind feature

What this PR does / why we need it:

This PR introduces StatePreservation to PropagationPolicy which will be used to preserve status in case of application failover.

Which issue(s) this PR fixes:
Part of #5788

Special notes for your reviewer:
This PR focuses on application failover behavior, for the cluster failover, will be included in a separate PR.

Does this PR introduce a user-facing change?:

`API Change`: Introduced `StatePreservation` to `PropagationPolicy`, which will be used to preserve status in case of application failover.

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 26, 2024
@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@RainbowMango
Copy link
Member Author

cc @mszacillo
This PR does not include cluster failover. I plan to consider it in a subsequent PR(likely in the next release), as it's more complex and involves changing the default behavior of cluster failover.
Let me know what do you think.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (5c3594f) to head (87ef7d0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5885      +/-   ##
==========================================
- Coverage   46.29%   46.29%   -0.01%     
==========================================
  Files         663      663              
  Lines       54585    54585              
==========================================
- Hits        25270    25268       -2     
- Misses      27690    27691       +1     
- Partials     1625     1626       +1     
Flag Coverage Δ
unittests 46.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@a7i a7i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

curious, could this not be achieved via a customized interpreter?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@mszacillo
Copy link
Contributor

This PR does not include cluster failover. I plan to consider it in a subsequent PR(likely in the next release), as it's more complex and involves changing the default behavior of cluster failover. Let me know what do you think.

Should be alright. Until then we can probably get around with our own local cluster failover change that would give us the failover flag like we want. Let me know if you need help with the cluster failover part!

@RainbowMango
Copy link
Member Author

/lgtm

curious, could this not be achieved via a customized interpreter?

Probably not, as the data could be grabbed from the status that has been collected to ResourceBinding, and I also made a demo for grabbing the data.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainbowMango
Copy link
Member Author

Until then we can probably get around with our own local cluster failover change that would give us the failover flag like we want. Let me know if you need help with the cluster failover part!

Absolutely, I'm glad to help. But I need to focus on the application failover part as I hope this could be included in this release.

@RainbowMango RainbowMango added this to the v1.12 milestone Nov 27, 2024
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit b399c8b into karmada-io:master Nov 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants