-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce StatePreservation to PropagationPolicy API #5885
Introduce StatePreservation to PropagationPolicy API #5885
Conversation
Signed-off-by: RainbowMango <[email protected]>
cc @mszacillo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5885 +/- ##
==========================================
- Coverage 46.29% 46.29% -0.01%
==========================================
Files 663 663
Lines 54585 54585
==========================================
- Hits 25270 25268 -2
- Misses 27690 27691 +1
- Partials 1625 1626 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
curious, could this not be achieved via a customized interpreter?
Should be alright. Until then we can probably get around with our own local cluster failover change that would give us the failover flag like we want. Let me know if you need help with the cluster failover part! |
Probably not, as the data could be grabbed from the status that has been collected to ResourceBinding, and I also made a demo for grabbing the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Absolutely, I'm glad to help. But I need to focus on the application failover part as I hope this could be included in this release. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
This PR introduces
StatePreservation
to PropagationPolicy which will be used to preserve status in case of application failover.Which issue(s) this PR fixes:
Part of #5788
Special notes for your reviewer:
This PR focuses on application failover behavior, for the cluster failover, will be included in a separate PR.
Does this PR introduce a user-facing change?: