Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for custom resource interpreter's configuration manager #5864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR adds comprehensive unit tests for the custom resource interpreter's configuration manager. The tests verify the core functionality of configuration management operations including script handling, merging behaviors, and dependency management.

Additions:

  1. pkg/resourceinterpreter/customized/declarative/configmanager/accessor_test.go

Test Coverage:

  1. pkg/resourceinterpreter/customized/declarative/configmanager/accessor.go: 30.70% → 100%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 22, 2024
@anujagrawal699
Copy link
Contributor Author

Hi @mohamedawnallah , found some flaky tests.

@XiShanYongYe-Chang
Copy link
Member

Hi @anujagrawal699 can you help rebase the newest master branch?

@anujagrawal699
Copy link
Contributor Author

Hi @anujagrawal699 can you help rebase the newest master branch?

Hi @XiShanYongYe-Chang , my branch is already up to date with master. I think the test is still flaky after the fix.

@XiShanYongYe-Chang
Copy link
Member

my branch is already up to date with master. I think the test is still flaky after the fix

I see. Thanks~ I'm going to keep an eye on it,

@XiShanYongYe-Chang
Copy link
Member

Ask @mohamedawnallah to help take a look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants