Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependenciesdistributor): remove dependenciesdistributor concurrentreconciles #5863

Conversation

CharlesQQ
Copy link
Contributor

@CharlesQQ CharlesQQ commented Nov 22, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
set concurrentreconciles for dependencies-distributor controller, which previously was a fixed value of 2;
value same as --concurrent-resourcebinding-syncs flag.

Which issue(s) this PR fixes:
part of #5790

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


…urrentreconciles same as concurrent-resourcebinding-syncs

Signed-off-by: chang.qiangqiang <[email protected]>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.33%. Comparing base (8691287) to head (fd9cd89).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
+ Coverage   46.32%   46.33%   +0.01%     
==========================================
  Files         661      661              
  Lines       54400    54400              
==========================================
+ Hits        25200    25207       +7     
+ Misses      27576    27570       -6     
+ Partials     1624     1623       -1     
Flag Coverage Δ
unittests 46.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RainbowMango RainbowMango changed the title feat(dependenciesdistributor): set dependenciesdistributor concurrentreconciles feat(dependenciesdistributor): remove dependenciesdistributor concurrentreconciles Nov 23, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2024
@karmada-bot karmada-bot merged commit 88c3e44 into karmada-io:master Nov 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants