Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make offscreen() use global onUpdate(), when pause: true, so it can detect when it comes back onscreen #537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dragoncoder047
Copy link
Contributor

closes #536

I also added this behavior behind a new flag, unpause, so users that are already using pause: true, won't get broken suddenly

@dragoncoder047 dragoncoder047 changed the title make offscreen() use global onUpdate(), when pause: true, so it can detect when it comes back onscreen fix: make offscreen() use global onUpdate(), when pause: true, so it can detect when it comes back onscreen Nov 24, 2024
Copy link

pkg-pr-new bot commented Nov 24, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@537

commit: 04f3590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug:offscreen({pause: true}) gets stuck once paused, must be unpaused manually
1 participant