Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress on MS extension support #30

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

Firstyear
Copy link
Member

Add support for MS OAPXBC key management in the soft-tpm, with a view to have this work with HW TPM's.

Checklist

  • [ x ] This pr contains no AI generated code
  • [ x ] cargo fmt has been run
  • [ x ] cargo clippy has been run and there's no issues
  • [ x ] cargo test has been run and passes

@dmulder
Copy link
Collaborator

dmulder commented Feb 9, 2024

Lgtm

@Firstyear Firstyear marked this pull request as ready for review February 13, 2024 07:09
@dmulder
Copy link
Collaborator

dmulder commented Feb 13, 2024

@Firstyear I don't have rights to merge, so you'll need to push the button yourself.

@dmulder
Copy link
Collaborator

dmulder commented Feb 13, 2024

FYI, I'm using your sealing code to prevent the release of the PRT:
himmelblau-idm/libhimmelblau@dd548ed
Technically a client with the TPM secrets could decrypt it, but I'm not enabling it. This way the PRT is a black box, that can be stashed in a database, then retrieved and passed to msal for authenticating later.

@Firstyear
Copy link
Member Author

@dmulder I don't know how I overlooked that, I gave you maintainer access now.

@Firstyear Firstyear merged commit c3148c1 into kanidm:main Feb 14, 2024
8 checks passed
@Firstyear Firstyear deleted the 20240208-ms-extension-support branch February 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants