Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Energy to Power for Firmware 3.2 #132

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

timovd
Copy link
Contributor

@timovd timovd commented Oct 18, 2023

Update Energy to Power for Firmware 3.2
https://github.com/Egyras/HeishaMon/releases/tag/v3.2

Update Energy to Power for Firmware 3.2
Update Energy to Power for Firmware 3.2
@geduxas
Copy link
Contributor

geduxas commented Oct 18, 2023

@timovd you should support both values, don't think that everyone will upgrade it soon :)

@Bucky2k
Copy link
Contributor

Bucky2k commented Oct 18, 2023

Indeed we need to realize a discover function to select either/or. It should not become a breaking change on HA Heishamon side

see #131 (comment)

@timovd
Copy link
Contributor Author

timovd commented Oct 19, 2023

If you're on fw <=3.1, you should use the old version of the integration. You cannot support all values forever.

@Bucky2k
Copy link
Contributor

Bucky2k commented Oct 19, 2023

Not so sure about that. People install HA, HACS and the Plugin being interested in onboarding Heishamon. And then per default/latest Version it does not work. Lots of complaints and issues will be raised.

Heishamon is often bought out of the box, I bet a significant portion of people do not know FW can be updated

@kamaradclimber
Copy link
Owner

If you're on fw <=3.1, you should use the old version of the integration. You cannot support all values forever.

FW 3.2 was released 2 days ago!
So I intend to keep compatibility with 3.1 and previous versions for some time (at least until I update my heishamon and probably for a lot longer).

AS @Bucky2k wrote, people can upgrade HA and custom integration very easily. Upgrading a firmware is not the same thing.

@kamaradclimber
Copy link
Owner

Anyway, thanks for the contribution. I think I'll merge as is this week end and add a patch to be backward compatible with version <= 3.1.

This discussion also gave me the idea of #133 which I hope I'll be able to implement in order to give a nice nudge for updates.

@kamaradclimber kamaradclimber merged commit ba13b66 into kamaradclimber:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants