remove the definition of deepcopy_internal

kalmarek · Dec 7, 2023 · b4e30ed · b4e30ed
1 parent 1fe60a6
commit b4e30ed
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/src/group_elements.jl b/src/group_elements.jl
@@ -27,17 +27,6 @@ Base.:(==)(g::GEl, h::GEl) where {GEl <: GroupElement} = throw(
     InterfaceNotImplemented(:Group, "Base.:(==)(::$GEl, ::$GEl)"),
 )
 
-Base.deepcopy_internal(g::GroupElement, stackdict::IdDict) = throw(
-    InterfaceNotImplemented(
-        :Group,
-        "Base.deepcopy_internal(::$(typeof(g)), ::IdDict)",
-    ),
-)
-# TODO: Technically, it is not necessary to implement `deepcopy_internal` method
-# if `parent(g)` can be reconstructed exactly from `g` (i.e. either it's cached,
-# or a singleton). However by defining this fallback we force everybody to
-# implement it, except isbits group elements.
-
 Base.copy(g::GroupElement) = deepcopy(g)
 
 @doc Markdown.doc"""

diff --git a/test/test_notsatisfied.jl b/test/test_notsatisfied.jl
@@ -113,7 +113,6 @@ end
 
         GroupsCore.isfiniteorder(::SomeGroupElement) = false
         @test_throws InfO order(g)
-        @test_throws INI deepcopy(g)
 
         @test_throws INI inv(g)
         @test_throws INI g * g