-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image asset complex field handler #203
base: main
Are you sure you want to change the base?
Image asset complex field handler #203
Conversation
=> Add ezimageasset as new fieldhandler for kaliop migration bundle
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
- Coverage 67.69% 67.56% -0.14%
- Complexity 2578 2585 +7
============================================
Files 123 124 +1
Lines 6714 6730 +16
============================================
+ Hits 4545 4547 +2
- Misses 2169 2183 +14
Continue to review full report at Codecov.
|
Nice, thanks. |
I will let @mpoudevigne answer as he was the one working on this :) |
=> Add kaliop tests files
@gggeek Can you say me if it's ok my kaliop migration files committed ? thanks |
@mpoudevigne yes, migration files are committed ok. I hope to merge and release soon |
@gggeek thanks |
// 2. resolve remote ids | ||
$id = $this->contentMatcher->matchOneByKey($id)->id; | ||
|
||
return new Value($id, $altText); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that the $id is int? I had similar issues when using references https://github.com/ezsystems/ezplatform-ee-demo/blob/v2.5.1/src/AppBundle/Migration/FieldHandler/EzImageAsset.php#L37
is your solution works with content exporter command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @florianalexandre any answer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any plans to merge this?
Add field handler for the ezplatform ezimageasset field type