Skip to content

Commit

Permalink
modify puppeteer pdf style detection due to false-positives
Browse files Browse the repository at this point in the history
  • Loading branch information
kaliiiiiiiiii committed Oct 21, 2024
1 parent 49786e8 commit 3a80068
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ detects injected javascript based on the stack trace in hooks

----
#### pdfStyle
a detection regarding PDF rendering, specific to puppeteer [github issue](https://github.com/kaliiiiiiiiii/brotector/issues/5)
a detection regarding PDF rendering,
specific to puppeteer [github issue](https://github.com/kaliiiiiiiiii/brotector/issues/5) or `--enable-field-trial-config` \
Note: There might be false-positives


----
#### popupCrash
Expand Down
Binary file modified assets/example_screenshot_headless.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion brotector.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class Brotector {
}
})
if(style){
this.log({detection:"pdfStyle",type:"puppeteer", score:0.9, data:{style:style}})
this.log({detection:"pdfStyle",score:0.5, data:{style:style}})
}
}
hook_mouseEvents() {
Expand Down

0 comments on commit 3a80068

Please sign in to comment.