Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unnecessary code from proto/varlogpb/log_entry.go #927

Open
wants to merge 1 commit into
base: tests_for_syncposition_and_syncrange
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 1, 2024

What this PR does

  • replaced InvalidLogEntry with an empty LogEntry across the codebase
  • removed proto/varlogpb/log_entry.go as it contained unused code
  • updated related files to reflect these changes

- replaced InvalidLogEntry with an empty LogEntry across the codebase
- removed proto/varlogpb/log_entry.go as it contained unused code
- updated related files to reflect these changes
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.30%. Comparing base (4499f90) to head (382277e).

Files with missing lines Patch % Lines
pkg/varlog/subscribe.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           tests_for_syncposition_and_syncrange     #927      +/-   ##
========================================================================
+ Coverage                                 67.20%   67.30%   +0.09%     
========================================================================
  Files                                       179      178       -1     
  Lines                                     21607    21599       -8     
========================================================================
+ Hits                                      14522    14538      +16     
+ Misses                                     6318     6305      -13     
+ Partials                                    767      756      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant