[Weekly/11/Test/Like] LikeControllerUnitTest 생성 (#141)

* test: Event Unit Test 리팩터링 * feat: Like 리팩터링 * feat: LikeData 추가 * test: LikeControllerUnitTest 생성
kakao-tech-campus-2nd-step3 · Nov 14, 2024 · 0a2cbee · 0a2cbee
1 parent e27b377
commit 0a2cbee
Show file tree

Hide file tree

Showing 10 changed files with 699 additions and 282 deletions.
diff --git a/src/main/java/org/ktc2/cokaen/wouldyouin/like/api/LikeController.java b/src/main/java/org/ktc2/cokaen/wouldyouin/like/api/LikeController.java
@@ -28,22 +28,28 @@ public class LikeController {
 
     @GetMapping
     public ResponseEntity<ApiResponseBody<LikeSliceResponse>> getLikes(
-        @Authorize(MemberType.normal) MemberIdentifier identifier,
+        @Authorize({MemberType.normal, MemberType.curator}) MemberIdentifier identifier,
         @RequestParam("type") MemberType memberType,
         @RequestParam(defaultValue = ParamDefaults.PAGE) Integer page,
         @RequestParam(defaultValue = ParamDefaults.PAGE_SIZE) Integer size,
         @RequestParam(defaultValue = ParamDefaults.LAST_ID) Long lastId
     ) {
         return ApiResponse.ok(
-            likeServiceFactory.getLikeServiceFrom(memberType)
-                .getLikes(identifier.id(), PageRequest.of(page, size), lastId));
+            likeServiceFactory
+                .getLikeServiceFrom(memberType)
+                .getLikes(identifier, PageRequest.of(page, size), lastId));
     }
 
     @PostMapping("/{targetMemberId}")
     public ResponseEntity<ApiResponseBody<LikeToggleResponse>> createOrDeleteLike(
-        @Authorize(MemberType.normal) MemberIdentifier identifier,
+        @Authorize({MemberType.normal, MemberType.curator}) MemberIdentifier identifier,
+        @RequestParam("type") MemberType memberType,
         @PathVariable("targetMemberId") Long targetId) {
         return ApiResponse.created(
-            likeServiceFactory.getLikeServiceFrom(targetId).toggleLike(identifier.id(), targetId));
+            likeServiceFactory.getLikeServiceFrom(memberType)
+                .toggleLike(identifier, targetId));
     }
 }
+
+// TODO: Like service에 Identifier 넘겨주기
+// TODO: Review service에 Identifier 넘겨주기
diff --git a/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/LikeService.java b/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/LikeService.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 import lombok.RequiredArgsConstructor;
+import org.ktc2.cokaen.wouldyouin.auth.MemberIdentifier;
 import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeResponse;
 import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeSliceResponse;
 import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeToggleResponse;
@@ -31,18 +32,18 @@ public abstract class LikeService<LikeType extends Like<? extends LikeableMember
     public abstract MemberType getTargetLikeableMemberType();
 
     @Transactional(readOnly = true)
-    public LikeSliceResponse getLikes(Long memberId, Pageable pageable, Long beforeLastId) {
+    public LikeSliceResponse getLikes(MemberIdentifier identifier, Pageable pageable, Long beforeLastId) {
         Slice<LikeType> likes = getLikeRepository().findAllByMember(
-            memberService.getByIdOrThrow(memberId), beforeLastId, pageable);
+            memberService.getByIdOrThrow(identifier.id()), beforeLastId, pageable);
         Long newLastId = getLastId(likes, beforeLastId);
         List<LikeResponse> responses = likes.stream()
             .map(like -> LikeResponse.from(like.getLikeableMember())).toList();
         return LikeSliceResponse.from(responses, likes.getSize(), newLastId);
     }
 
     @Transactional
-    public LikeToggleResponse toggleLike(Long memberId, Long targetMemberId) {
-        Member member = memberService.getByIdOrThrow(memberId);
+    public LikeToggleResponse toggleLike(MemberIdentifier identifier, Long targetMemberId) {
+        Member member = memberService.getByIdOrThrow(identifier.id());
         LikeableMember targetLikeableMember = getLikeableMemberByIdOrThrow(targetMemberId);
         return getLikeRepository().findByMemberAndLikeableMember(member, targetLikeableMember)
             .map(like -> {

diff --git a/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/dto/LikeResponse.java b/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/dto/LikeResponse.java
@@ -0,0 +1,31 @@
+
+package org.ktc2.cokaen.wouldyouin.like.api.dto;
+
+import java.util.List;
+import lombok.AccessLevel;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.ktc2.cokaen.wouldyouin.member.persist.LikeableMember;
+
+@Getter
+@RequiredArgsConstructor(access = AccessLevel.PROTECTED)
+@Builder
+public class LikeResponse {
+
+    private final Long memberId;
+    private final String nickname;
+    private final String intro;
+    private final List<String> hashtags;
+    private final String profileImageUrl;
+
+    public static LikeResponse from(LikeableMember member) {
+        return LikeResponse.builder()
+            .memberId(member.getId())
+            .nickname(member.getNickname())
+            .intro(member.getIntro())
+            .hashtags(member.getHashtags())
+            .profileImageUrl(member.getProfileImageUrl())
+            .build();
+    }
+}
diff --git a/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/dto/LikeToggleResponse.java b/src/main/java/org/ktc2/cokaen/wouldyouin/like/application/dto/LikeToggleResponse.java
@@ -0,0 +1,20 @@
+package org.ktc2.cokaen.wouldyouin.like.application.dto;
+
+import lombok.AccessLevel;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.ktc2.cokaen.wouldyouin.member.persist.LikeableMember;
+
+@Getter
+@RequiredArgsConstructor(access = AccessLevel.PROTECTED)
+@Builder
+public class LikeToggleResponse {
+    private final boolean isLiked;
+
+    public static LikeToggleResponse from(boolean state) {
+        return LikeToggleResponse.builder()
+            .isLiked(state)
+            .build();
+    }
+}
diff --git a/src/test/java/org/ktc2/cokaen/wouldyouin/_global/mockMember/WithMockCurator1.java b/src/test/java/org/ktc2/cokaen/wouldyouin/_global/mockMember/WithMockCurator1.java
@@ -8,5 +8,5 @@
 @Retention(RetentionPolicy.RUNTIME)
 @WithMockCustomUser(memberId = curator1.id, memberType = MemberType.curator)
 public @interface WithMockCurator1 {
-
+    // TODO: mockMember 패키지명 변경
 }
diff --git a/src/test/java/org/ktc2/cokaen/wouldyouin/_global/testdata/CommonData.java b/src/test/java/org/ktc2/cokaen/wouldyouin/_global/testdata/CommonData.java
@@ -2,7 +2,9 @@
 
 import org.ktc2.cokaen.wouldyouin._common.api.SliceInfo;
 import org.ktc2.cokaen.wouldyouin._global.testdata.CurationData.R.curation1;
+import org.ktc2.cokaen.wouldyouin._global.testdata.MemberData.R;
 import org.ktc2.cokaen.wouldyouin._global.testdata.MemberData.R.curator1;
+import org.ktc2.cokaen.wouldyouin._global.testdata.MemberData.R.host1;
 import org.ktc2.cokaen.wouldyouin._global.testdata.ReservationData.R.reservation1;
 import org.ktc2.cokaen.wouldyouin._global.testdata.ReviewData.R.review1;
 
@@ -26,13 +28,36 @@ public static SliceInfo get() {
         }
 
         public static class like {
-
-                public static SliceInfo get() {
-                    return SliceInfo.builder()
-                        .sliceSize(2)
-                        .lastId(curator1.id)
-                        .build();
+            public static class normal1 {
+                public static class hostLikes {
+                    public static SliceInfo get() {
+                        return SliceInfo.builder()
+                            .sliceSize(1)
+                            .lastId(host1.id)
+                            .build();
+                    }
+                }
+                public static class curatorLikes {
+                    public static SliceInfo get() {
+                        return SliceInfo.builder()
+                            .sliceSize(1)
+                            .lastId(R.curator1.id)
+                            .build();
+                    }
+                }
+            }
+            public static class curator1 {
+                public static class hostLikes {
+                    public static SliceInfo get() {
+                        return SliceInfo.builder()
+                            .sliceSize(1)
+                            .lastId(host1.id)
+                            .build();
+                    }
                 }
+            }
+
+
         }
 
         public static class reservation {

diff --git a/src/test/java/org/ktc2/cokaen/wouldyouin/_global/testdata/LikeData.java b/src/test/java/org/ktc2/cokaen/wouldyouin/_global/testdata/LikeData.java
@@ -1,8 +1,11 @@
 package org.ktc2.cokaen.wouldyouin._global.testdata;
 
 import java.util.List;
+import org.ktc2.cokaen.wouldyouin._global.testdata.LikeData.R.likeHost1.byNormal1;
+import org.ktc2.cokaen.wouldyouin._global.testdata.LikeData.R.likeHost1.byNormal1.create;
 import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeResponse;
 import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeSliceResponse;
+import org.ktc2.cokaen.wouldyouin.like.api.dto.LikeToggleResponse;
 import org.ktc2.cokaen.wouldyouin.like.persist.CuratorLike;
 import org.ktc2.cokaen.wouldyouin.like.persist.HostLike;
 import org.ktc2.cokaen.wouldyouin.member.persist.Curator;
@@ -29,6 +32,10 @@ public static class response {
                     public static final List<String> hashtags = MemberData.R.host1.hashtags;
                     public static final String profileImageUrl = MemberData.R.host1.profileImageUrl;
                 }
+                public static class create{
+                    public static final Boolean created = true;
+                    public static final Boolean deleted = false;
+                }
             }
             public static class byCurator1 {
                 public static class _Relation {
@@ -46,6 +53,10 @@ public static class response {
                     public static final List<String> hashtags = MemberData.R.host1.hashtags;
                     public static final String profileImageUrl = MemberData.R.host1.profileImageUrl;
                 }
+                public static class create{
+                    public static final Boolean created = true;
+                    public static final Boolean deleted = false;
+                }
             }
         }
         public static class likeCurator1 {
@@ -137,28 +148,71 @@ public static LikeResponse get() {
             }
         }
     }
+    public static class toggleResponse{
+        public static class hostLikes {
+            public static class create {
 
-    public static class normal1LikeSliceResponse {
-        public static LikeSliceResponse get() {
-            return LikeSliceResponse.builder()
-                .likes(List.of(
-                    LikeResponse.builder()
-                        .memberId(R.likeHost1.byNormal1.response.id)
-                        .nickname(R.likeHost1.byNormal1.response.nickname)
-                        .intro(R.likeHost1.byNormal1.response.intro)
-                        .hashtags(R.likeHost1.byNormal1.response.hashtags)
-                        .profileImageUrl(R.likeHost1.byNormal1.response.profileImageUrl)
-                        .build(),
-                    LikeResponse.builder()
-                        .memberId(R.likeCurator1.byNormal1.response.id)
-                        .nickname(R.likeCurator1.byNormal1.response.nickname)
-                        .intro(R.likeCurator1.byNormal1.response.intro)
-                        .hashtags(R.likeCurator1.byNormal1.response.hashtags)
-                        .profileImageUrl(R.likeCurator1.byNormal1.response.profileImageUrl)
-                        .build()
-                ))
-                .sliceInfo(CommonData.sliceInfo.like.get())
-                .build();
+                public static LikeToggleResponse get() {
+                    return LikeToggleResponse.builder().isLiked(byNormal1.create.created).build();
+                }
+            }
+            public static class delete {
+
+                public static LikeToggleResponse get() {
+                    return LikeToggleResponse.builder().isLiked(byNormal1.create.deleted).build();
+                }
+            }
+        }
+    }
+    public static class sliceResponse {
+        public static class normal1 {
+            public static class hostLikes {
+                public static LikeSliceResponse get() {
+                    return LikeSliceResponse.builder()
+                        .likes(List.of(
+                            LikeResponse.builder()
+                                .memberId(R.likeHost1.byNormal1.response.id)
+                                .nickname(R.likeHost1.byNormal1.response.nickname)
+                                .intro(R.likeHost1.byNormal1.response.intro)
+                                .hashtags(R.likeHost1.byNormal1.response.hashtags)
+                                .profileImageUrl(R.likeHost1.byNormal1.response.profileImageUrl)
+                                .build()))
+                        .sliceInfo(CommonData.sliceInfo.like.normal1.hostLikes.get())
+                        .build();
+                }
+            }
+            public static class curatorLikes {
+                public static LikeSliceResponse get() {
+                    return LikeSliceResponse.builder()
+                        .likes(List.of(
+                            LikeResponse.builder()
+                                .memberId(R.likeCurator1.byNormal1.response.id)
+                                .nickname(R.likeCurator1.byNormal1.response.nickname)
+                                .intro(R.likeCurator1.byNormal1.response.intro)
+                                .hashtags(R.likeCurator1.byNormal1.response.hashtags)
+                                .profileImageUrl(R.likeCurator1.byNormal1.response.profileImageUrl)
+                                .build()))
+                        .sliceInfo(CommonData.sliceInfo.like.normal1.curatorLikes.get())
+                        .build();
+                }
+            }
+        }
+        public static class curator1 {
+            public static class hostLikes {
+                public static LikeSliceResponse get() {
+                    return LikeSliceResponse.builder()
+                        .likes(List.of(
+                            LikeResponse.builder()
+                                .memberId(R.likeHost1.byCurator1.response.id)
+                                .nickname(R.likeHost1.byCurator1.response.nickname)
+                                .intro(R.likeHost1.byCurator1.response.intro)
+                                .hashtags(R.likeHost1.byCurator1.response.hashtags)
+                                .profileImageUrl(R.likeHost1.byCurator1.response.profileImageUrl)
+                                .build()))
+                        .sliceInfo(CommonData.sliceInfo.like.curator1.hostLikes.get())
+                        .build();
+                }
+            }
         }
     }
 }