-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전남대 BE_나제법 5주차(3단계) #427
Open
nove1080
wants to merge
143
commits into
kakao-tech-campus-2nd-step2:nove1080
Choose a base branch
from
nove1080:step3
base: nove1080
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
전남대 BE_나제법 5주차(3단계) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- /api/login/oauth2/kakao 추가
- LoginRequest.java - Password.java - schema.sql
- @ConfigurationPropertiesScan - @EnableFeignClients
- Member의 password 필드 삭제로 인한 테스트 코드 수정이 필요함
# Conflicts: # src/main/resources/static/category.html # src/main/resources/static/docs.html # src/main/resources/static/login.html # src/main/resources/static/member.html # src/main/resources/static/product.html # src/test/java/gift/web/controller/api/ProductApiControllerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API 문서 위치
API 명세서는
resources/static/docs.html
에 모두 기록되어 있습니다!과제를 진행하며 어려웠던 점
1. 쿼리파라미터만 추가된 엔드포인트 대해 테스트가 수행되지 않습니다
categoryId 를 쿼리파라미터로 받는 엔드포인트(
readAllProductsByCategoryId
)에 대해서 요청을 보내면readAllProducts
여기로 요청이 나가는 것 같습니다. 무슨 문제인지 잘 모르겠습니다 이 문제를 스스로 해결하지 못해서 아직/api/products?categoryId
명세를 작성하지 못하였습니다. (ProductApiControllerTest
에 주석 처리하였습니다) 스스로 해결하지 못할 것 같아 이 문제에 대해 멘토님의 조언을 듣고 싶습니다.궁금한 점
1. 어노테이션을 붙이는 순서도 나름의 기준이 있나요?
위와 같이 여러 어노테이션이 붙게 되는 경우 어노테이션을 붙이는 순서(어떤 어노테이션이 더 위에 있고 밑에 있는지)도 나름의 기준이 있나요? 멘토님의 생각이 궁금합니다
2. 컨트롤러 테스트 코드에 대한 피드백을 받고 싶습니다
Mockito
를 사용한 테스트를 하는게 익숙하지 않아 개선할 부분을 알려주시면 많은 도움이 될 것 같습니다!3. 실무에서는 어떻게 API 명세서를 관리하나요?
동건님 덕분에 몰랐던 부분도 많이 알게되고 재밌게 공부하고 있습니다 항상 감사합니다!!!