전남대 BE_유보민 5주차 과제 (3단계) #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunom
approved these changes
Jul 28, 2024
| headers.add("Authorization", "Bearer " + token); | ||
| headers.setContentType(MediaType.APPLICATION_FORM_URLENCODED); | ||
|
|
||
| TextObject textObject = new TextObject( |
There was a problem hiding this comment.
여기부터 78번째 코드까지를 추상화시킬 수 있을 거 같아요. TextObject가 messageString을 반환하는 메소드를 가지고 있으면 더 쉽게 사용할 수 있을 거 같네요?
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| String jsonTextObject = objectMapper.writeValueAsString(textObject); | ||
|
|
||
| MultiValueMap<String, Object> body = new LinkedMultiValueMap<>(); |
There was a problem hiding this comment.
Map사용이 번거롭다면 별도의 요청 클래스를 만들어 ResponseBody 클래스를 사용하면 좋습니다 :)
| for (OrderRequestDto orderRequestDto : orderRequestDtoList) { | ||
| Product product = productJpaRepository.findById(orderRequestDto.getProductId()).orElseThrow(); | ||
| Option option = optionJpaRepository.findById(orderRequestDto.getOptionId()).orElseThrow(); | ||
| message.append("상품 이름 : ") |
There was a problem hiding this comment.
상품 메시지를 하나의 도메인으로 만들면 좋을 거 같아요. product의 이름, option의 이름, 수량을 필드로 가지고 String으로 변환하는 메소드를 가지는 클래스면 훨씬 객체지향적일 거 같네요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger를 통해 api 문서를 만들어보았습니다! 피드백 해주시면 감사하겠습니다.