전남대 BE_조설빈 5주차 과제 (1단계) #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungy0
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
좋습니다. 도메인 객체가 컨트롤러에 노출되는 것만 지향하시면 더 좋겠습니다.
There was a problem hiding this comment.
과제 요구사항 밖일 수 있으나, 생각해보면 카테고리를 누구나 수정, 삭제할 수 있는 건 조금 이상한 것 같습니다.
| @GetMapping("/") | ||
| public RedirectView callback(@RequestParam(name = "code") String code, RedirectAttributes redirectAttributes) throws Exception { | ||
| String token = kakaoService.login(code); | ||
| redirectAttributes.addFlashAttribute("token", token); |
Comment on lines
+48
to
+53
| ResponseEntity<String> entity = client.post() | ||
| .uri(URI.create(url)) | ||
| .contentType(MediaType.APPLICATION_FORM_URLENCODED) | ||
| .header(HttpHeaders.AUTHORIZATION, "Bearer " + accessToken) | ||
| .retrieve() | ||
| .toEntity(String.class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.