-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경북대 FE_정지원 5주차 과제 STEP2~3 #58
Open
Diwoni
wants to merge
17
commits into
kakao-tech-campus-2nd-step2:diwoni
Choose a base branch
from
Diwoni:step2
base: diwoni
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
안녕하세요 지원님! 전체 코드리뷰
README.md 퀴즈질문 1: 테스트 코드를 작성해보면서 좋았던 점과 아쉬웠던 점
질문 2: 스스로 생각했을 때 좋은 컴포넌트란 무엇인지 본인만의 기준
질문 3: 스스로 생각했을 때 공통 컴포넌트를 만들 때 가장 중요한 요소 2개
마지막 코멘트
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
경북대 FE_정지원 5주차 과제 STEP2~3
시간적 여유가 없어, chatGPT 도움을 많이 받았던 과제였던 것 같습니다.
그래도 그 과정에서 mock 핸들러를 구현할 때 코드 틀을 짜는 것에 대해 손에 익힐 수 있었고,
중간부터는 스스로 구현할 수 있는 부분은 해보았던 것 같습니다.
Step1 에서 결제 페이지의 통합 테스트는 실패하였는데, 주말에 다시 한 번 수정해볼 생각입니다 :)