-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
강원대 FE_김정윤 2주차 과제 Step1 #50
Open
wjdsbs
wants to merge
16
commits into
kakao-tech-campus-2nd-step2:wjdsbs
Choose a base branch
from
wjdsbs:step1
base: wjdsbs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님! 이번 주도 쉽지 않았던 것 같습니다. 잘 부탁드립니다!!
궁금한 점
컴포넌트를 많이 사용하는 페이지의 컴포넌트들을 MainPage, ThemePage처럼 폴더를 만들어 담게 되었는데, 프로젝트가 커지는 경우 바람직하지 못한 방식일지 궁금합니다.
Theme 페이지 구현에서 재사용성을 고려하여 Header 섹션을 만든다는 부분을 잘 이해하지 못하여 많이 해매고 GPT도움도 많이 받았습니다. 일단 지금은 Theme 객체 한 개를 themes에 담아 놓은 상태인데, 나중에 백엔드와 합치게 되면 서버에서 Key와 value를 받아 Theme 페이지를 각각 다르게 출력하게 되는건가요? 또 그렇게 한다면 현재 코드에서 큰 수정이 필요한 상태인지 궁금합니다.