전남대_FE_이은진 2주차 과제 step3 #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 3, 2024 23:13
tlsehdfl
reviewed
Jul 5, 2024
| const [username, setUsername] = useState<string | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| const token = getAuthToken(); |
There was a problem hiding this comment.
authToken 을 username 으로 지정하는 이유가 있을까요 ? 다른 학생도 이런식으로 구현했던데...
보통 authToken 이라고 하면 login api 호출하여 취득한 accessToken 을 말합니다.
유저의 이름을 sessionStorage 에 저장하여 authToken 처럼 사용하는건 지양해야 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님 !
2주차 과제 step3까지 최종 제출입니다 :)